V3 calendar #629
Merged
V3 calendar #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 10, 2024 17:36
…e unused components
weili-govtech
requested changes
Dec 11, 2024
Comment on lines
+30
to
57
| case "hover-subtle": | ||
| color = Colour["bg-hover"]; | ||
| borderColor = Colour["bg-hover"]; | ||
| break; | ||
| case "hover-current": | ||
| color = V2_Color.Neutral[8]; | ||
| border = `1px solid ${V2_Color.Primary(props)}`; | ||
| case "hover": | ||
| color = Colour["bg-hover-strong"]; | ||
| borderColor = Colour["bg-hover-strong"]; | ||
| break; | ||
| case "selected": | ||
| color = V2_Color.Accent.Light[5]; | ||
| border = `1px solid ${V2_Color.Accent.Light[4](props)}`; | ||
| case "hover-outline": | ||
| color = Colour["bg-hover-subtle"]; | ||
| borderColor = Colour["border-hover"]; | ||
| break; | ||
| case "selected-outline": | ||
| color = V2_Color.Accent.Light[5]; | ||
| border = `1px solid ${V2_Color.Primary(props)}`; | ||
| color = Colour["bg-selected"]; | ||
| borderColor = Colour["border-selected"]; | ||
| break; | ||
| case "overlap": | ||
| color = V2_Color.Accent.Light[4]; | ||
| border = `1px solid ${V2_Color.Accent.Light[4](props)}`; | ||
| case "selected-outline-subtle": | ||
| color = Colour["bg-selected"]; | ||
| borderColor = Colour["border-selected-subtle"]; | ||
| break; | ||
| case "overlap-outline": | ||
| color = V2_Color.Accent.Light[4]; | ||
| border = `1px solid ${V2_Color.Primary(props)}`; | ||
| case "selected-hover": | ||
| color = Colour["bg-selected-hover"]; | ||
| // no border to give it an overlay effect | ||
| break; | ||
| case "selected-hover-outline": | ||
| color = Colour["bg-selected-hover"]; | ||
| borderColor = Colour["border-selected-hover"]; | ||
| break; |
There was a problem hiding this comment.
just wondering if it is possible to align with UX on the naming of various states?
There was a problem hiding this comment.
due to the different possible combinations of elements across components, and the modular implementation of the day cell, the naming of CellType can't be 1:1 with the elements. but UX has suggested to include a mapping in Figma to bridge this difference
weili-govtech
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
known issue: the day view peeks out behind the month/year view on mobile date input. will be fixing separately as it may involve shifting some styles from parent to children