Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IPFS integration #34

Closed
wants to merge 2 commits into from
Closed

Conversation

Vectorrent
Copy link
Contributor

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

Implements the use_ipfs argument, as documented here.

IPFS nodes will not respond to ping in the way Hivemind expects, so we also set ensure_bootstrap_success to False, when IPFS is used. Nevertheless, HivemindStrategy will connect to peers successfully once training begins.

@Vectorrent Vectorrent requested a review from Borda as a code owner December 15, 2023 03:27
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #34 (e6fa0b4) into main (2c83356) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #34   +/-   ##
==================================
  Coverage    86%   86%           
==================================
  Files         3     3           
  Lines       167   167           
==================================
  Hits        144   144           
  Misses       23    23           

@Vectorrent
Copy link
Contributor Author

Closing this, because I couldn't add additional commits to it. That feature requires a branch in my remote repo - which I've created now, in #35 .

@Vectorrent Vectorrent closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant