emulation_defender_machine_observation_state.py #197
Conversation
| @@ -131,7 +133,14 @@ def to_dict(self) -> Dict[str, Any]: | |||
|
|
|||
| :return: a dict representation of the object | |||
| """ | |||
| d = {} | |||
| if self.ports == [] or self.ssh_connections == []: | |||
There was a problem hiding this comment.
We probably want to allow both empty lists and None here in the Dict, i.e not raise an exception. Does mypy require an exception? We have Dict[str, Any] so it should work.
There was a problem hiding this comment.
Ja, det blir ett mypy-error om man inte tar hänsyn till None. Anledningen är för att vi måste anropa to_dict(), som inte finns om item är None. Dock kan jag göra så att jag bara lägger till None isåfall(?).
There was a problem hiding this comment.
Det blir bra, kör en if-else framför varje to_dict, och lägg till None i dicten om den är None
There was a problem hiding this comment.
Kör samma på copy(), if-else framför varje copy och lägg till None om den är None
| @@ -173,6 +182,8 @@ def cleanup(self) -> None: | |||
|
|
|||
| :return: None | |||
| """ | |||
| if self.ossec_ids_alert_counters is None: | |||
There was a problem hiding this comment.
There is a bug in the method here. This if-statement can be removed and later down where it says ossec_ids_alert_counters.running it should be changed to ossec_ids_log_consumer_thread.running
| @@ -192,6 +203,12 @@ def copy(self) -> "EmulationDefenderMachineObservationState": | |||
| """ | |||
| :return: a copy of the object | |||
| """ | |||
| if self.host_metrics is None or \ | |||
There was a problem hiding this comment.
Certain attributes of the class have type Optional. For these attributes we dont want to raise an exception, we can simply assign them to None in the object
There was a problem hiding this comment.
Also ports can be empty list, there is no problem with that
There was a problem hiding this comment.
Check if there is any type that we dont allow to be None in the class, then we check it and raise exception, otherwise we can assign it to None and Mypy should be ok
| self.docker_stats_consumer_thread = None | ||
| self.snort_ids_log_consumer_thread = None | ||
| self.ossec_ids_log_consumer_thread = None | ||
| self.host_metrics_consumer_thread: Optional[HostMetricsConsumerThread] = None |
|
Har exkluderat ValueErrors på to_dict och copy och har istället integrerat None |
No description provided.