alpha_vectors_policy.py #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok bra input, ska kolla på det |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Det finns många ställen där vi får ett mypy-error pga att vi har typat en parameter som Union[List[float], in float] och i funktionen antagit att det måste vara en List eftersom vi indexerar. Det går inte riktigt att spåra om det är en bugg eller inte då alla variabler i koden som så småningom tas som en parameter till ett anrop till action (i det här falllet) är typade på samma sätt.
Man skulle kunna göra en if-sats och lösa det på så vis (tror jag gjort det någon gång tidigare) men det känns fel att börja blanda in typing i logiken hos funktionerna (annat än isinstance).