Add fullscreen feature and pixel formatting fix #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding fullscreen (just landscape without any controls, size is the same for now).
Also noticed that mapping pixels was wrong. I turned 2 grayscale value into one rgb565 which is now how that works. Somehow I never noticed. The approach to map the pixels should not impact performance at all.
Not sure about making fullscreen any larger though. The size is just not enough to justify another dithermap (8x instead of 4x). Scaling the dithered image might work, but would add a lot of extra cpu overhead and the bigger image in general might also hurt performance on top (maybe not on the rM 1, not sure). So not sure if it would be even worth it.
Binary for commit c6761f9: doomarkable.zip
Fullscreen can be accessed from the settings and the user gets informed on how to exit again and that he should have a keyboard present.
@Eeems do you think this would work? I think #2 would be done then.