Add support for phpcs #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WengerK
reviewed
May 18, 2018
runners/phpcs/script.sh
Outdated
|
|
||
| ARGS=( $DRUPAL_TI_PHPCS_ARGS ) | ||
|
|
||
| $HOME/.composer/vendor/bin/phpcs "${ARGS[@]}" |
There was a problem hiding this comment.
What about also using phpcsp (Code Sniffer Drupal Practice) ?
ARGS=( $DRUPAL_TI_PHPCSP_ARGS )
$HOME/.composer/vendor/bin/phpcsp "${ARGS[@]}"
There was a problem hiding this comment.
I'm not familiar with the phpcsp binary. Is there something I can read to learn about it?
I made a couple of modifications to provide default arguments and to make it easier to invoke drupal/coder standards.
WengerK
requested changes
Sep 25, 2018
| ARGS=( | ||
| "--colors" | ||
| "--standard=Drupal,DrupalPractice" | ||
| "--extensions=php,module,inc,install,test,profile,theme,css,info,txt,md" |
There was a problem hiding this comment.
I'm not sure you should lint css files :D
|
Seems this needs a little bit more work to be ready :) |
|
Closing this as outdated. Thanks for the consideration and feedback for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12 (plus one typo).
Let me know any changes you'd like to see!