Update tests for interop cross chain updates (#9138)

* Update tests for interop cross chain updates * expect `verifyRoutingRules` to return error in all cases * Move repeated declarations to parent scope * Use ccmContext instead * Remove `// ***` * Remove `describe('isMainchain'` to have all checks inside a single `describe('verifyRoutingRules'` * use chainID other than mainchainID * `Sending and receiving chains must differ.` condition should run for both (mainchain & sidechain) cases * Address redundant assignments * Removing expectation, since following expects will fail, if there is no error throw from verifyRoutingRules --------- Co-authored-by: !shan <ishantiw.quasar@gmail.com>
LiskArchive · Nov 23, 2023 · 7d8301a · 7d8301a
1 parent 799585e
commit 7d8301a
Show file tree

Hide file tree

Showing 6 changed files with 279 additions and 169 deletions.
diff --git a/framework/src/modules/interoperability/base_cross_chain_update_command.ts b/framework/src/modules/interoperability/base_cross_chain_update_command.ts
@@ -123,6 +123,7 @@ export abstract class BaseCrossChainUpdateCommand<
 		}
 	}
 
+	// https://github.com/LiskHQ/lips/blob/main/proposals/lip-0053.md#beforecrosschainmessagesexecution
 	protected async beforeCrossChainMessagesExecution(
 		context: CommandExecuteContext<CrossChainUpdateTransactionParams>,
 		isMainchain: boolean,
@@ -195,6 +196,7 @@ export abstract class BaseCrossChainUpdateCommand<
 		return [ccms, true];
 	}
 
+	// https://github.com/LiskHQ/lips/blob/main/proposals/lip-0053.md#verifyroutingrules
 	protected verifyRoutingRules(
 		ccm: CCMsg,
 		ccuParams: CrossChainUpdateTransactionParams,
@@ -219,7 +221,8 @@ export abstract class BaseCrossChainUpdateCommand<
 		}
 	}
 
-	protected async afterCrossChainMessagesExecute(
+	// https://github.com/LiskHQ/lips/blob/main/proposals/lip-0053.md#aftercrosschainmessagesexecution
+	protected async afterCrossChainMessagesExecution(
 		context: CommandExecuteContext<CrossChainUpdateTransactionParams>,
 	) {
 		const { params } = context;

diff --git a/...rk/src/modules/interoperability/mainchain/commands/submit_mainchain_cross_chain_update.ts b/...rk/src/modules/interoperability/mainchain/commands/submit_mainchain_cross_chain_update.ts
@@ -128,7 +128,7 @@ export class SubmitMainchainCrossChainUpdateCommand extends BaseCrossChainUpdate
 			context.contextStore.delete(CONTEXT_STORE_KEY_CCM_PROCESSING);
 		}
 
-		await this.afterCrossChainMessagesExecute(context);
+		await this.afterCrossChainMessagesExecution(context);
 	}
 
 	private async _beforeCrossChainMessageForwarding(

diff --git a/...rk/src/modules/interoperability/sidechain/commands/submit_sidechain_cross_chain_update.ts b/...rk/src/modules/interoperability/sidechain/commands/submit_sidechain_cross_chain_update.ts
@@ -26,7 +26,6 @@ import { getIDFromCCMBytes } from '../../utils';
 import { SidechainInteroperabilityInternalMethod } from '../internal_method';
 
 // https://github.com/LiskHQ/lips/blob/main/proposals/lip-0053.md#sidechaincrosschainupdate
-
 export class SubmitSidechainCrossChainUpdateCommand extends BaseCrossChainUpdateCommand<SidechainInteroperabilityInternalMethod> {
 	public async verify(
 		context: CommandVerifyContext<CrossChainUpdateTransactionParams>,
@@ -81,6 +80,6 @@ export class SubmitSidechainCrossChainUpdateCommand extends BaseCrossChainUpdate
 			context.contextStore.delete(CONTEXT_STORE_KEY_CCM_PROCESSING);
 		}
 
-		await this.afterCrossChainMessagesExecute(context);
+		await this.afterCrossChainMessagesExecution(context);
 	}
 }