Merge pull request #130 from LiskHQ/fix_detached_fork_func

Fix detached function not to throw - Closes #129
LiskArchive · Sep 12, 2019 · baf2745 · baf2745
2 parents cefffa7 + 609cdf9
commit baf2745
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/framework/src/modules/chain/rounds/delegates.js b/framework/src/modules/chain/rounds/delegates.js
@@ -217,7 +217,11 @@ class Delegates {
 			cause,
 		};
 
-		await this.storage.entities.Account.insertFork(fork);
+		try {
+			await this.storage.entities.Account.insertFork(fork);
+		} catch (err) {
+			this.logger.warn(err, 'Failed to insert fork info');
+		}
 		this.channel.publish('chain:delegates:fork', fork);
 	}
 

diff --git a/framework/test/mocha/unit/modules/chain/submodules/delegates.js b/framework/test/mocha/unit/modules/chain/submodules/delegates.js
@@ -34,6 +34,7 @@ describe('delegates', () => {
 	const mockLogger = {
 		debug: sinonSandbox.stub(),
 		info: sinonSandbox.stub(),
+		warn: sinonSandbox.stub(),
 		error: sinonSandbox.stub(),
 	};
 	const mockStorage = {
@@ -112,6 +113,25 @@ describe('delegates', () => {
 					fork,
 				);
 			});
+
+			it('should not throw an error when the database fails', async () => {
+				const fork = {
+					delegatePublicKey: dummyBlock.generatorPublicKey,
+					blockTimestamp: dummyBlock.timestamp,
+					blockId: dummyBlock.id,
+					blockHeight: dummyBlock.height,
+					previousBlockId: dummyBlock.previousBlock,
+					cause,
+				};
+				mockStorage.entities.Account.insertFork.rejects(
+					new Error('invalid DB state'),
+				);
+				await delegatesModule.fork(dummyBlock, cause);
+				expect(mockChannel.publish).to.be.calledWithExactly(
+					'chain:delegates:fork',
+					fork,
+				);
+			});
 		});
 
 		describe('#generateDelegateList', () => {