This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Unit test review - Interoperability genesis state initialization/finalization #8980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/6.1.0 #8980 +/- ##
==============================================
Coverage 84.33% 84.34%
==============================================
Files 652 652
Lines 23964 23963 -1
Branches 3487 3487
==============================================
+ Hits 20211 20212 +1
+ Misses 3753 3751 -2
|
sitetester
commented
Sep 14, 2023
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
ishantiw
suggested changes
Sep 15, 2023
There was a problem hiding this comment.
- We can be consistent with other test suites in the SDK following the pattern of, describe blocks for each method and if it needs further describe it with words, for example, the below desc block doesn't really speak much,
https://github.com/LiskHQ/lisk-sdk/blob/17d63fb6fbe509b38288fafe681456d122d8b0ce/framework/test/unit/modules/interoperability/base_interoperability_module.spec.ts#L352
framework/test/unit/modules/interoperability/base_interoperability_module.spec.ts
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
ishantiw
suggested changes
Sep 19, 2023
gkoumout
suggested changes
Sep 20, 2023
framework/test/unit/modules/interoperability/base_interoperability_module.spec.ts
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_interoperability_module.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
gkoumout
reviewed
Sep 22, 2023
framework/test/unit/modules/interoperability/base_interoperability_module.spec.ts
Outdated
Show resolved
Hide resolved
gkoumout
approved these changes
Sep 27, 2023
framework/test/unit/modules/interoperability/base_interoperability_module.spec.ts
Show resolved
Hide resolved
ishantiw
reviewed
Sep 28, 2023
framework/test/unit/modules/interoperability/base_interoperability_module.spec.ts
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
sitetester
force-pushed
the
8378-interop_genesis_state_initialization_finalization
branch
from
bb2f8aa to
24bf961
Compare
…zation_finalization
ishantiw
approved these changes
Oct 13, 2023
ishantiw
deleted the
8378-interop_genesis_state_initialization_finalization
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8378
How was it solved?
Went through source code & corresponding tests added/updated. Also mainchain:_verifyTerminatedStateAccounts(...) is updated.
How was it tested?
Added/updated tests are passing