Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

PoA Improvements #2 #8991

Merged
merged 6 commits into from
Sep 20, 2023
Merged

PoA Improvements #2 #8991

merged 6 commits into from
Sep 20, 2023

Conversation

Phanco
Copy link
Contributor

@Phanco Phanco commented Sep 14, 2023

What was the problem?

This PR resolves #8964

How was it solved?

  1. RegisterAuthorityParams reordered
  2. Skipped as it has been resolved by PR Update poa module schema validation and endpoint #8967
  3. isBufferArrayOrdered in initGenesisState
  4. shuffleValidatorList in PoA is removed and solely using PoS

How was it tested?

Test Cases Passed

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #8991 (3db42a3) into release/6.1.0 (3db42a3) will not change coverage.
The diff coverage is n/a.

❗ Current head 3db42a3 differs from pull request most recent head f10ff86. Consider uploading reports for the commit f10ff86 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.1.0    #8991   +/-   ##
==============================================
  Coverage          84.36%   84.36%           
==============================================
  Files                650      650           
  Lines              24026    24026           
  Branches            3494     3494           
==============================================
  Hits               20269    20269           
  Misses              3757     3757           

@Phanco Phanco marked this pull request as ready for review September 14, 2023 10:54
framework/src/modules/poa/module.ts Outdated Show resolved Hide resolved
framework/src/modules/poa/module.ts Outdated Show resolved Hide resolved
@Phanco Phanco requested a review from ishantiw September 19, 2023 16:01
@ishantiw ishantiw enabled auto-merge (squash) September 20, 2023 15:11
@ishantiw ishantiw merged commit 5ec14a0 into release/6.1.0 Sep 20, 2023
8 checks passed
@ishantiw ishantiw deleted the 8964-poa-improvement-2 branch September 20, 2023 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants