Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove deprecated slice function #8997

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

mosmartin
Copy link
Contributor

What was the problem?

This PR resolves #8984

How was it solved?

Replaced all instances of the deprecated Buffer.slice function with Buffer.subarray

How was it tested?

All tests pass

@mosmartin mosmartin requested review from shuse2 and Incede September 15, 2023 14:46
@mosmartin mosmartin self-assigned this Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #8997 (159fc36) into release/6.1.0 (6615719) will increase coverage by 0.00%.
Report is 9 commits behind head on release/6.1.0.
The diff coverage is 98.41%.

❗ Current head 159fc36 differs from pull request most recent head 0d28cad. Consider uploading reports for the commit 0d28cad to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.1.0    #8997   +/-   ##
==============================================
  Coverage          84.36%   84.36%           
==============================================
  Files                650      650           
  Lines              24031    24022    -9     
  Branches            3491     3490    -1     
==============================================
- Hits               20273    20266    -7     
+ Misses              3758     3756    -2     
Files Changed Coverage
elements/lisk-chain/src/state_store/state_store.ts ø
elements/lisk-chain/src/state_store/utils.ts ø
elements/lisk-cryptography/src/nacl/slow.ts ø
...k/src/modules/nft/commands/transfer_cross_chain.ts ø
framework/src/modules/nft/schemas.ts ø
framework/src/modules/poa/schemas.ts ø
...rk/src/state_machine/prefixed_state_read_writer.ts ø
...ework/src/modules/poa/commands/update_authority.ts 90.00%
elements/lisk-chain/src/data_access/storage.ts 100.00%
elements/lisk-cryptography/src/address.ts 100.00%
... and 23 more

@shuse2 shuse2 enabled auto-merge (squash) September 19, 2023 20:45
@shuse2 shuse2 merged commit a7cc944 into release/6.1.0 Sep 19, 2023
8 checks passed
@shuse2 shuse2 deleted the 8984-remove-deprecated-function branch September 19, 2023 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants