Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix absolute path issue and add export-json flag #9020

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

ishantiw
Copy link
Contributor

What was the problem?

This PR resolves #9013 #9019

How was it solved?

♻️ Manage different file paths #9013 and 🌱 add export-json flag #9019

How was it tested?

  • ./bin/run init ~/Desktop/pathTest
  • cd pathTest
  • copy paste commander/dist/bootstrapping/commands/genesis-block/create.js from commander into your newly built pathTest app node_modules/lisk-commander/dist/bootstrapping/commands/genesis-block/create.js
  • Run multiple formats of data path into genesis-block:create command
    • ./bin/run genesis-block:create --output ../ --assets-file config/default/genesis_assets.json
    • ./bin/run genesis-block:create --output ~/Desktop --assets-file config/default/genesis_assets.json
    • ./bin/run genesis-block:create --output /User/username/Desktop/pathTest/config/default --assets-file config/default/genesis_assets.json
      and check whether it is creating the file at the desired location
  • Check if the JSON format is exported on using --export-json flag : ./bin/run genesis-block:create --output ../ --assets-file config/default/genesis_assets.json --export-json

@ishantiw ishantiw self-assigned this Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #9020 (b2779e1) into release/6.0.0 (5e6cf7c) will decrease coverage by 0.03%.
The diff coverage is 22.22%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #9020      +/-   ##
=================================================
- Coverage          83.55%   83.53%   -0.03%     
=================================================
  Files                603      603              
  Lines              22661    22668       +7     
  Branches            3348     3351       +3     
=================================================
+ Hits               18934    18935       +1     
- Misses              3727     3733       +6     
Files Changed Coverage
...src/bootstrapping/commands/genesis-block/create.ts 22.22%

@ishantiw ishantiw requested a review from shuse2 September 20, 2023 11:54
@ishantiw ishantiw merged commit ce2ecb6 into release/6.0.0 Sep 20, 2023
@ishantiw ishantiw deleted the 9013-fix-absolute-path-issue branch September 20, 2023 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants