Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Unit test review: Dynamic block rewards #9104

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

Incede
Copy link
Contributor

@Incede Incede commented Oct 19, 2023

What was the problem?

This PR resolves #8025

How was it solved?

  • / with BigInt is equivalent to // in LIP hence no change required
  • updated terminology and added comment to indicate formulation of BigInt(5)
  • moved specified tests to beforeTransactionsExecute
  • no change required for setting context
  • added unit test "Should not store timestamp when it is not end of round"
  • other 2 tests suggested are not in the scope of unit test for this particular module

How was it tested?

Updated unit tests pass

@Incede Incede requested review from shuse2 and vjaiman October 19, 2023 03:54
@Incede Incede self-assigned this Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #9104 (8e1c5a0) into release/6.1.0 (36a1df9) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 8e1c5a0 differs from pull request most recent head 8db170d. Consider uploading reports for the commit 8db170d to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.1.0    #9104      +/-   ##
=================================================
- Coverage          84.35%   84.34%   -0.01%     
=================================================
  Files                652      652              
  Lines              23970    23966       -4     
  Branches            3490     3489       -1     
=================================================
- Hits               20219    20215       -4     
  Misses              3751     3751              

see 2 files with indirect coverage changes

Copy link

@vjaiman vjaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@shuse2 shuse2 enabled auto-merge (squash) October 31, 2023 09:57
@shuse2 shuse2 merged commit 223afce into release/6.1.0 Nov 1, 2023
8 checks passed
@shuse2 shuse2 deleted the 8025-unit-test branch November 1, 2023 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants