This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Update getChildQueue to replace default topic #9110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/6.0.0 #9110 +/- ##
=================================================
+ Coverage 83.47% 83.50% +0.03%
=================================================
Files 604 606 +2
Lines 22790 22822 +32
Branches 3363 3365 +2
=================================================
+ Hits 19023 19058 +35
+ Misses 3767 3764 -3
|
ishantiw
force-pushed
the
9099-update-event-queue
branch
from
October 19, 2023 20:55
f58d8f2
to
4cf2c5e
Compare
shuse2
reviewed
Oct 20, 2023
framework/src/modules/interoperability/mainchain/commands/recover_message.ts
Outdated
Show resolved
Hide resolved
ricott1
approved these changes
Oct 20, 2023
shuse2
suggested changes
Oct 20, 2023
...ework/src/modules/interoperability/mainchain/commands/submit_mainchain_cross_chain_update.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/events/invalid_outbox_root_verification.ts
Outdated
Show resolved
Hide resolved
...ework/src/modules/interoperability/mainchain/commands/submit_mainchain_cross_chain_update.ts
Show resolved
Hide resolved
- getChildQueue is updated to replace default topic - Transaction execution to have a transactionID with prefix as default topic - CCM execution to have a ccmID with prefix as default topic
- Create Panic function to exit application on unexpected error while CCU execution - Add events to verifyPartnerChainOutboxRoot on smt and partnerOutbox failure #9111 - Rename executeCommon->beforeCrossChainMessagesExecution - Add verifyRoutingRules similar to LIP0053 - Move verifyCertificateSignature and verifyPartnerChainOutboxRoot outside beforeCrossChainMessagesExecution and call before it #9112 - Move constant EVENT_TOPIC_CCM_EXECUTION to interoperability module
ishantiw
force-pushed
the
9099-update-event-queue
branch
from
October 21, 2023 13:13
47192ff
to
f20d1c1
Compare
ricott1
reviewed
Oct 21, 2023
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Outdated
Show resolved
Hide resolved
ricott1
reviewed
Oct 21, 2023
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Outdated
Show resolved
Hide resolved
ricott1
reviewed
Oct 21, 2023
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Outdated
Show resolved
Hide resolved
ricott1
reviewed
Oct 21, 2023
...ework/src/modules/interoperability/sidechain/commands/submit_sidechain_cross_chain_update.ts
Show resolved
Hide resolved
ricott1
reviewed
Oct 21, 2023
...ework/src/modules/interoperability/sidechain/commands/submit_sidechain_cross_chain_update.ts
Show resolved
Hide resolved
ricott1
reviewed
Oct 21, 2023
framework/src/modules/interoperability/base_cross_chain_update_command.ts
Outdated
Show resolved
Hide resolved
shuse2
approved these changes
Oct 21, 2023
framework/src/modules/interoperability/events/invalid_outbox_root_verification.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #9099 #9100 #9111 #9112
How was it solved?
How was it tested?
Setup 2 sidechains and 2 mainchain nodes using interop examples and try to send invalid CCM from sidechainTwo to sidechainOne using React Module.