Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update getChildQueue to replace default topic #9110

Merged
merged 6 commits into from
Oct 22, 2023

Conversation

ishantiw
Copy link
Contributor

@ishantiw ishantiw commented Oct 19, 2023

What was the problem?

This PR resolves #9099 #9100 #9111 #9112

How was it solved?

  • getChildQueue is updated to replace default topic
  • Transaction execution to have a transactionID with prefix as default topic
  • CCM execution to have a ccmID with prefix as default topic

How was it tested?

Setup 2 sidechains and 2 mainchain nodes using interop examples and try to send invalid CCM from sidechainTwo to sidechainOne using React Module.

@ishantiw ishantiw requested review from shuse2 and ricott1 October 19, 2023 15:44
@ishantiw ishantiw self-assigned this Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #9110 (f3650e7) into release/6.0.0 (21f0182) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #9110      +/-   ##
=================================================
+ Coverage          83.47%   83.50%   +0.03%     
=================================================
  Files                604      606       +2     
  Lines              22790    22822      +32     
  Branches            3363     3365       +2     
=================================================
+ Hits               19023    19058      +35     
+ Misses              3767     3764       -3     
Files Coverage Δ
...nteroperability/base_cross_chain_update_command.ts 97.71% <100.00%> (+0.06%) ⬆️
...rability/base_interoperability_internal_methods.ts 94.13% <100.00%> (+1.20%) ⬆️
...s/interoperability/base_interoperability_module.ts 99.22% <100.00%> (+0.01%) ⬆️
...rc/modules/interoperability/base_state_recovery.ts 100.00% <100.00%> (ø)
...ramework/src/modules/interoperability/constants.ts 100.00% <100.00%> (ø)
...ability/events/invalid_outbox_root_verification.ts 100.00% <100.00%> (ø)
...nteroperability/events/invalid_rmt_verification.ts 100.00% <100.00%> (ø)
...nteroperability/events/invalid_smt_verification.ts 100.00% <100.00%> (ø)
...roperability/mainchain/commands/recover_message.ts 99.38% <100.00%> (ø)
...in/commands/submit_mainchain_cross_chain_update.ts 98.76% <100.00%> (+0.04%) ⬆️
... and 7 more

... and 2 files with indirect coverage changes

@ishantiw ishantiw force-pushed the 9099-update-event-queue branch from f58d8f2 to 4cf2c5e Compare October 19, 2023 20:55
- getChildQueue is updated to replace default topic
- Transaction execution to have a transactionID with prefix as default topic
- CCM execution to have a ccmID with prefix as default topic
- Create Panic function to exit application on unexpected error while CCU execution
- Add events to verifyPartnerChainOutboxRoot on smt and partnerOutbox failure #9111
- Rename executeCommon->beforeCrossChainMessagesExecution
- Add verifyRoutingRules similar to LIP0053
- Move verifyCertificateSignature and verifyPartnerChainOutboxRoot outside beforeCrossChainMessagesExecution and call before it #9112
- Move constant EVENT_TOPIC_CCM_EXECUTION to interoperability module
@ishantiw ishantiw force-pushed the 9099-update-event-queue branch from 47192ff to f20d1c1 Compare October 21, 2023 13:13
@ishantiw ishantiw marked this pull request as ready for review October 21, 2023 13:13
@ishantiw ishantiw requested a review from shuse2 October 21, 2023 13:13
@ishantiw ishantiw merged commit bf141fb into release/6.0.0 Oct 22, 2023
10 checks passed
@ishantiw ishantiw deleted the 9099-update-event-queue branch October 22, 2023 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants