Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Improve logging and handling of syncing node in chain connector plugin #9121

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

ishantiw
Copy link
Contributor

What was the problem?

This PR resolves #9116 #9120

How was it solved?

♻️ Handle syncing node and error logging

How was it tested?

Run interop examples and stop mainchain node 2 for sometime and start is after sometime and see if the CCUs are being sent to sidechain-two

@ishantiw ishantiw self-assigned this Oct 23, 2023
@ishantiw ishantiw requested review from shuse2 and mitsuaki-u October 23, 2023 14:32
…ain_connector_plugin.ts

Co-authored-by: shuse2 <shuse2@users.noreply.github.com>
@ishantiw ishantiw requested a review from Phanco October 23, 2023 15:33
@ishantiw ishantiw removed the request for review from mitsuaki-u October 23, 2023 15:39
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #9121 (fe89199) into release/6.0.0 (a943cd0) will decrease coverage by 0.01%.
The diff coverage is 80.95%.

❗ Current head fe89199 differs from pull request most recent head 70b8ebf. Consider uploading reports for the commit 70b8ebf to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.0.0    #9121      +/-   ##
=================================================
- Coverage          83.51%   83.51%   -0.01%     
=================================================
  Files                606      606              
  Lines              22823    22828       +5     
  Branches            3365     3365              
=================================================
+ Hits               19060    19064       +4     
- Misses              3763     3764       +1     
Files Coverage Δ
...ain-connector-plugin/src/certificate_generation.ts 97.95% <100.00%> (+0.04%) ⬆️
...ain-connector-plugin/src/chain_connector_plugin.ts 78.24% <73.33%> (+0.26%) ⬆️

... and 1 file with indirect coverage changes

@ishantiw ishantiw enabled auto-merge (squash) October 23, 2023 15:48
@ishantiw ishantiw merged commit 4994353 into release/6.0.0 Oct 23, 2023
8 checks passed
@ishantiw ishantiw deleted the 9116-improve-logging branch October 23, 2023 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants