This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Make --output
flag support all types of paths
#9169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.1.0 #9169 +/- ##
=================================================
- Coverage 84.65% 84.65% -0.01%
=================================================
Files 655 656 +1
Lines 24113 24122 +9
Branches 3497 3497
=================================================
+ Hits 20414 20420 +6
- Misses 3699 3702 +3
|
has5aan
approved these changes
Dec 4, 2023
has5aan
reviewed
Dec 4, 2023
ishantiw
suggested changes
Dec 4, 2023
commander/test/bootstrapping/commands/passphrase/encrypt.spec.ts
Outdated
Show resolved
Hide resolved
commander/test/bootstrapping/commands/passphrase/encrypt.spec.ts
Outdated
Show resolved
Hide resolved
ishantiw
approved these changes
Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #9090
How was it solved?
Created the
handleOutputFlag
utility function.With this utiliy, it's now possible to generate output files with following commands
./bin/run generator export
will generate a file with the default namespace name in thecwd
../bin/run generator export --output .
will generate a file with the default namespace name in thecwd
../bin/run generator export --output ./
will generate a file with the default namespace name in thecwd
../bin/run generator export --output test.json
will generate the file with the provided filename in thecwd
../bin/run generator export --output ~
will generate a file with the default namespace name in the user home dir../bin/run generator export --output ~/Desktop/
will generate a file with the default namespace name in the user desktop../bin/run generator export --output exports
will generate a file with the default namespace name in the defined dir (exports
) incwd
./bin/run generator export --output /Users/johndoe/Public/test.json
will generate thetest.json
file in the defined pathHow was it tested?
Updated and added new tests