This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Add/Update events unit tests #9173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the event name to conform to alphanumeric
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.1.0 #9173 +/- ##
=================================================
- Coverage 84.65% 84.65% -0.01%
=================================================
Files 655 655
Lines 24113 24113
Branches 3497 3497
=================================================
- Hits 20414 20413 -1
- Misses 3699 3700 +1 |
ricott1
reviewed
Dec 8, 2023
| @@ -82,14 +100,38 @@ describe('event', () => { | |||
| expect(topicIndex).toEqual(i); | |||
| } | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Do we already have a test on the number of topics? I.e. testing that the length of the topics array is <= MAX_TOPICS_PER_EVENT?
There was a problem hiding this comment.
This has not been implemented in the file under test.
ricott1
suggested changes
Dec 8, 2023
|
Created a new issue to address this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8066
How was it solved?
Added new and updated existing unit tests
How was it tested?
Added new and updated existing unit tests