Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add ability to save inclusion proofs at every new block #9197

Merged
merged 8 commits into from
Mar 6, 2024

Conversation

ishantiw
Copy link
Contributor

@ishantiw ishantiw commented Feb 2, 2024

What was the problem?

This PR resolves #9194

How was it solved?

  • Add config to take keepInclusionProofsForHeights and inclusionProofKeys
  • Add DB update to get/set/delete inclusionProofs
  • Add handler in new block event to save inclusion proofs
  • Add endpoint for chain to get inclusion proofs by height

How was it tested?

  • Run interop examples and call endpoint chain_getInclusionProofsAtHeight with height to see the proofs being stored at new bock

- Add config to take keepInclusionProofsForHeights and inclusionProofKeys
- Add DB update to get/set/delete inclusionProofs
- Add handler in new block event to save inclusion proofs
- Add endpoint for chain to get inclusion proofs by height
@ishantiw ishantiw requested review from shuse2 and Incede February 2, 2024 10:51
@ishantiw ishantiw self-assigned this Feb 2, 2024
@ishantiw ishantiw force-pushed the 9194-save-inclusion-proof branch from ccf6a67 to 2cace9d Compare February 11, 2024 16:36
@ishantiw ishantiw requested a review from shuse2 February 11, 2024 16:36
@ishantiw ishantiw marked this pull request as ready for review February 11, 2024 16:36
Copy link
Contributor

@Incede Incede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of questions in addition to minor naming suggestions.

@ishantiw ishantiw requested a review from Incede February 29, 2024 19:24
Copy link
Contributor

@Incede Incede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of unresolved conversations but feel free to resolve them.

@ishantiw ishantiw enabled auto-merge (squash) March 6, 2024 08:38
@ishantiw ishantiw merged commit 39c521f into hotfix/6.0.2 Mar 6, 2024
9 checks passed
@ishantiw ishantiw deleted the 9194-save-inclusion-proof branch March 6, 2024 11:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants