This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Add ability to save inclusion proofs at every new block #9197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add config to take keepInclusionProofsForHeights and inclusionProofKeys - Add DB update to get/set/delete inclusionProofs - Add handler in new block event to save inclusion proofs - Add endpoint for chain to get inclusion proofs by height
shuse2
reviewed
Feb 7, 2024
ishantiw
force-pushed
the
9194-save-inclusion-proof
branch
from
February 11, 2024 16:36
ccf6a67
to
2cace9d
Compare
Incede
suggested changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of questions in addition to minor naming suggestions.
shuse2
approved these changes
Mar 5, 2024
Incede
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of unresolved conversations but feel free to resolve them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #9194
How was it solved?
How was it tested?
chain_getInclusionProofsAtHeight
with height to see the proofs being stored at new bock