(feature) Add Stage Manager (com.apple.WindowManager) settings

[malko42]

All credits go to @AlexOwl. Their PR looked abandonned so I reported their changes and addressed the change requests.

[Samasaur1]

Assuming that you've tested it and that those are still the correct defaults keys to use for those settings, this looks good to me

[malko42]

Hi @Samasaur1 and thanks for the review!
If you compare this PR with the orginal one the options are not the same. I added and tested only the options that I was interested in. I'm not sure about the default values though I took my own system as reference since I haven't touched those options AFAIK but still not 100% sure.
Is there an up-to-date list somewhere listing all com.apple.* settings ?

Also there are a few commonly defined options in Nix config files do you want me to add them in a later PR or on this one ?

[Samasaur1]

Hi @Samasaur1 and thanks for the review!

If you compare this PR with the orginal one the options are not the same. I added and tested only the options that I was interested in. I'm not sure about the default values though I took my own system as reference since I haven't touched those options AFAIK but still not 100% sure.

I think you're right about the default values. I also don't think it really matters all too much because I think if people are looking at these options, they're probably planning to set them anyway.

I did look again at your EnableStandardClickToShowDesktop option, and I think you should update the docs you wrote for it to say that false means "Only in Stage Manager" and true means Always

Is there an up-to-date list somewhere listing all com.apple.* settings ?

Wouldn't that be nice! I wish. I know there's https://macos-defaults.com/ and maybe other sites like it, but I don't think they're comprehensive

Also there are a few commonly defined options in Nix config files do you want me to add them in a later PR or on this one ?

I'd say you should feel free to add any options under com.apple.WindowManager in this PR, but other defaults options should have their own PRs

[Enzime]

Can you rebase your branch on top of master and squash all your commits into a singular one?

[malko42]

Few things to note:

• I added all the options I could effectively test
• I named the options after the ones from Apple but I'm not happy with it. I find them at best non explicit and most of the time logically opposite of their UI counterpart

[Enzime]

Can you update the tests?

https://github.com/LnL7/nix-darwin/blob/master/tests/fixtures/system-defaults-write/activate-user.txt
https://github.com/LnL7/nix-darwin/blob/master/tests/system-defaults-write.nix

[malko42]

Can you update the tests?

https://github.com/LnL7/nix-darwin/blob/master/tests/fixtures/system-defaults-write/activate-user.txt https://github.com/LnL7/nix-darwin/blob/master/tests/system-defaults-write.nix

Done

[Enzime]

LGTM

Thanks for the contribution