-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature) Add Stage Manager (com.apple.WindowManager) settings #1002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that you've tested it and that those are still the correct defaults keys to use for those settings, this looks good to me
Hi @Samasaur1 and thanks for the review! Also there are a few commonly defined options in Nix config files do you want me to add them in a later PR or on this one ? |
I think you're right about the default values. I also don't think it really matters all too much because I think if people are looking at these options, they're probably planning to set them anyway. I did look again at your
Wouldn't that be nice! I wish. I know there's https://macos-defaults.com/ and maybe other sites like it, but I don't think they're comprehensive
I'd say you should feel free to add any options under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase your branch on top of master and squash all your commits into a singular one?
55c07ec
to
7da98c0
Compare
Few things to note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the contribution
All credits go to @AlexOwl. Their PR looked abandonned so I reported their changes and addressed the change requests.