defaults: only restart Dock when user is logged in #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enzime
force-pushed
the
fix/dock-not-running
branch
from
05b5784
to
a566238
Compare
emilazy
requested changes
Jul 26, 2024
| echo >&2 "restarting Dock..." | ||
| killall Dock | ||
| # Only restart Dock if current user is logged in | ||
| if pgrep -xu $UID Dock; then |
There was a problem hiding this comment.
Shouldn’t need this with the || true.
There was a problem hiding this comment.
I would rather leave it in as it makes the intent of this code more clear (the prerequisite of restarting the Dock is when it is running as the current user)
There was a problem hiding this comment.
Alright; it’ll be a little awkward in a post‐user‐activation world but we can cross that bridge when we come to it.
emilazy
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can occur if your primary user is not logged in and you try to do a
darwin-rebuild switch