github-runners: move workDir
outside of /run
#1018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I messed up when testing #1013 and forgot to reboot when testing and the PR didn't actually work.
As
/run
gets recreated every reboot and we can't specify dependencies for launchd, creating theworkDir
every reboot will require extra complexity with a separate daemon that runs asroot
otherwise it won't have sufficient privileges.As we clean the
workDir
when the service first starts anyway, it ends up being the same.