ssh: fix public keys in home directory not working #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domenkozar can you take a look at this PR? due to #654 I'm no longer able to SSH into macOS as I was managing my public keys manually in |
|
Do we need to delete .orig? |
|
That file gets generated only when the contents matches exactly what this module used to generate, so the likelihood it came from somewhere else is low. My thought process was remove it in an attempt to make the migration not leave behind a byproduct. |
|
I'm afraid that it would be generated for some other reason and we're deleting it. To be on the safe side, let's leave it around. |
|
Would you be okay with deleting it if I change it to only delete if it matches the hash? |
amarshall
reviewed
Jun 8, 2023
Enzime
force-pushed
the
fix/ssh-pubkeys
branch
2 times, most recently
from
b81f7c4
to
0ae683b
Compare
Added `services.openssh.authorizedKeysFiles` option from NixOS.
domenkozar
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my testing,
101-authorized-keys.confdoesn't need to be a regular file either, so I've added logic to migrate seamlessly to a symlink.