nix/linux-builder: init #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enzime
force-pushed
the
add/linux-builder
branch
from
1189ed2
to
6301909
Compare
LnL7
reviewed
Jun 20, 2023
| sshKey = "/etc/nix/builder_ed25519"; | ||
| system = "${stdenv.hostPlatform.uname.processor}-linux"; | ||
| supportedFeatures = [ "kvm" "benchmark" "big-parallel" ]; | ||
| publicHostKey = "c3NoLWVkMjU1MTkgQUFBQUMzTnphQzFsWkRJMU5URTVBQUFBSUpCV2N4Yi9CbGFxdDFhdU90RStGOFFVV3JVb3RpQzVxQkorVXVFV2RWQ2Igcm9vdEBuaXhvcwo="; |
There was a problem hiding this comment.
Is this completely static? Would be better to retrieve this information from an attribute of the builder package if possible.
There was a problem hiding this comment.
The host key is currently completely static, the host keys are files in the Nixpkgs tree and are not easily overridable, this value comes from the Nixpkgs documentation:
Enzime
force-pushed
the
add/linux-builder
branch
2 times, most recently
from
07f6ce8
to
8f96eed
Compare
|
@LnL7 @domenkozar Since the upstream PR has landed in nixpkgs, I think this is ready for review/merge :) Very excited about this! Thanks for pushing it forward @Enzime :) |
domenkozar
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
darwin.builderas alaunchdservice 🎉Depends on NixOS/nixpkgs#236389 as it expects
darwin.builderto run on port 31022 by default