etc: check for existing files during checks stage #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enzime
requested changes
Jul 13, 2023
|
Pushed with ShellCheck suggestions. I am once again recalibrating my metric for how defensive I should be when programming in shell. |
Enzime
approved these changes
Jul 16, 2023
This ensures that activation fails early if there are any `/etc` files with unexpected state, rather than leaving the system half-activated.
|
Separated out variable renames to hopefully make the diff easier to read for future spelunkers. No change to the final tree. (Have to ask for re-approval, unfortunately.) |
|
@emilazy it's still approved FYI as you didn't make any overall changes |
|
Didn't realize it worked that way! Okay, merging this; fingers crossed. (We need VM tests...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that activation fails early if there are any
/etcfiles with unexpected state, rather than leaving the system half-activated.Here be dragons, obviously; it would be quite bad to get anything wrong. I tried to write this as clearly as possible and I think it's a lot easier to follow than the previous version, but it should still be carefully reviewed. It worked for all the cases I tested. I endeavoured to follow the logic of the previous version as closely as possible, except for two cases, which should both be more conservative than the previous version:
/etcfile containing the string/etc/staticas carte blanche to overwrite it. (Why would we...? This one really confuses me. @LnL7 do you remember what's going on there?)/etc/staticonly when the file in/etc/staticdirectly doesn't exist, not when recursively dereferencing symbolic links leads to a nonexistent file.