-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
programs.nh: init module #942
base: master
Are you sure you want to change the base?
Conversation
Does the |
Yes? I wouldn't have worked on this otherwise. Only the |
nh doesn't wrap nix-darwin. And I don't use macOs, so thought has not been put into making sure the rest works there. |
Could you explain why you said that? I'm not sure what point you're trying to make. |
I don't know what is to explain, nh doesn't support |
The The |
I think perhaps the meaning of "support" here is overloaded. I'll try to clarify, please correct me if I'm wrong:
As |
My understanding is that nh was written by @viperML and this version does not support darwin as @viperML does not have a Mac to be able to test. The nh module here can be made to use @ToyVo s fork and so is fully functional on macOS. By setting programs.nh.package |
To add the comment from @bestlem, there are 2 side of the "not supported": A) Not supporting darwin as the run-time platform for |
@viperML I'm still not sure what the point is you're trying to make. What is the reason for you saying that darwin isn't supported? What do you hope to achieve? Is there something that you think I should do with regard to this PR? |
@alanpearce What @viperML is saying that his code might or might not run on darwin and if you find an issue with his original on darwin he can't investigate so can't fix it. You run his executable at your own risk and the author can't answer anything about issues. @viperML is not being awkward here they are just saying that they can't deal with darwin issues. This is fair as they can't test, To test things you have to have all the different hardware and operating systems that your customers use. You can do this if you are reasonably sized organisation but no-one can expect single person FOSS developers to do this. This is no doubt one of the reason nix-darwin exists it can deal with issues that are different to nixes. |
@LnL7 when will you merge this? This is a great edition. |
@SolidRhino the nh-darwin fork does have a Darwin module that defines the same options if you are impatient for this pr. I have also recently closed an issue that pointed out that there was indeed a bug with nh os clean on macos that I have since fixed. That bug was macos uids start at 501 so the original nh would clean xdg directories for users 1000-1100, now on nh-dawrin the appropriate users 501-601 are cleaned. |
Hey, can we get this merged? Thanks! |
Based on the NixOS module of the same name.
I used the same checks that
nix.gc
uses, as it performs exactly that function.