Ijod #914
Open
Ijod #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code/logic in the process
…now between synclets and push
|
getCurrent is unlost and functioning. |
|
This is now ready to merge and start testing on our sandbox. I'd appreciate any final reviews before I pull the trigger. There is a verification tool in the Ops directory called checkCurrent.js. It is ran such as: |
This reverts commit 2df12ab.
This reverts commit 7735358.
This changes transactions so it has actual transaction rollback. The batch add defaults to using this with 5 attempts to land a commit. I'm going fail hard if those 5 attempts fail until I understand why it's failing.
This stuff is much more transparent if we push it into the source tree, rather than putting it in the jenkins config. To the greatest extent possible, Jenkins should just run "make jenkins" and let us take care of the rest here.
| @@ -27,36 +26,24 @@ module.exports = function(locker) { | |||
| }); | |||
| }); | |||
|
|
|||
| // copy pasta from the synclet code, these should be utilizing some generic stuff instead | |||
There were known and unknown logic bombs in the code that have been purged by this pass. All scheduling is centralized and synclets are only executed from one location now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implemens ijod for core synclet results.
A few of the highlights now are:
There are currently two primary TODOs before looking to merge.
Please test this branch and see how it feels.