chore: add soebelow and dialyzer (commented out), split steps (#2097)

* chore: add soebelow and dialyzer to ci * chore: comment out dialyzer and sobelow * chore: update action name * chore: adjust makefile test * chore: change test command * chore: add wal_level config * chore: add connection values * fix: name of matrix * chore: set wal level in test_helper * chore: add comments * chore: formatting * chore: streamline setup migration * chore: add deps compilation * chore: add test env var * chore: add cargo lockfile to cache key * chore: use setup file mount * chore: try using supabase postges * chore: use bitnami * chore: use specfic image * chore: increase health retries * chore: update health check
Logflare · Jul 18, 2024 · 26c3548 · 26c3548
1 parent d406a8d
commit 26c3548
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 26 deletions.
diff --git a/.github/workflows/elixir-ci.yml b/.github/workflows/elixir-ci.yml
@@ -19,25 +19,45 @@ on:
 permissions:
   contents: read
 
+env:
+  MIX_ENV: test
+
+
 jobs:
-  build:
-    name: Build and test
+  check:
+    name: Checks
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        commands:
+          - name: Code Quality - Linting
+            run: mix lint --only warnings
+          - name: Code Quality - Formatting
+            run: mix test.format
+          - name: Compilation Warnings
+            run: mix test.compile
+          - name: Tests
+            run: mix do ecto.create, ecto.migrate, test
+          # - name: Security - Sobelow Code Scan
+          #   run: mix test.security
+          # - name: Typing check
+          #   run: mix test.typings
     services:
       postgres:
-        image: postgres:13
+        image: bitnami/postgresql:13.15.0
         ports:
           - 5432:5432
         env:
           POSTGRES_USER: postgres
           POSTGRES_PASSWORD: postgres
           POSTGRES_DB: logflare_test
+          POSTGRESQL_WAL_LEVEL: logical
         # Set health checks to wait until postgres has started
         options: >-
-          --health-cmd pg_isready
+          --health-cmd "pg_isready -d logflare_test -U postgres -p 5432"
           --health-interval 10s
           --health-timeout 5s
-          --health-retries 5
+          --health-retries 10
     env:
       MIX_ENV: test
       SHELL: /bin/bash
@@ -57,23 +77,11 @@ jobs:
         with:
           path: |
             deps
-          key: ${{ runner.os }}-mix-${{ hashFiles('**/mix.lock') }}
-          restore-keys: ${{ runner.os }}-mix-
+            _build
+            dialyzer
+          key: ${{ runner.os }}-mix-${{  hashFiles('**/mix.lock', '**/Cargo.lock' ) }}
+          restore-keys: ${{ runner.os }}-mix--dialyzer
       - name: Install dependencies
-        run: mix deps.get
-      - name: Run DB migrations
-        run: MIX_ENV=test mix do ecto.create, ecto.migrate
-      - name: Run compilation warnings check
-        run: mix test.compile
-      - name: Run migrations for test environment
-        run: MIX_ENV=test mix do ecto.drop, ecto.create, ecto.migrate
-      - name: Run unit tests with code coverage check
-        run: make test
-    # - name: Test - security
-    #   run: mix test.security
-      - name: Code quality - formatting
-        run: mix test.format
-    # - name: Code quality - typings
-    #   run: mix test.typings
-      - name: Code quality - linting
-        run: mix lint --only warnings
+        run: mix do deps.get, deps.compile
+      - name: Run ${{ matrix.commands.name }}
+        run: ${{ matrix.commands.run }}
diff --git a/.gitignore b/.gitignore
@@ -5,6 +5,8 @@
 /*.ez
 .DS_Store
 
+dialyzer
+
 # Generated on crash by the VM
 erl_crash.dump
 

diff --git a/Makefile b/Makefile
@@ -14,7 +14,7 @@ help:
 
 test:
 	-epmd -daemon
-	mix test.coverage
+	mix test
 
 test.only:
 	-epmd -daemon

diff --git a/mix.exs b/mix.exs
@@ -24,6 +24,10 @@ defmodule Logflare.Mixfile do
         "coveralls.post": :test,
         "coveralls.html": :test
       ],
+      dialyzer: [
+        plt_local_path: "dialyzer",
+        plt_core_path: "dialyzer"
+      ],
       test_coverage: [tool: ExCoveralls],
       releases: [
         logflare: [
@@ -234,7 +238,7 @@ defmodule Logflare.Mixfile do
       "test.compile": ["compile --warnings-as-errors"],
       "test.format": ["format --check-formatted"],
       "test.security": ["sobelow --threshold high --ignore Config.HTTPS"],
-      "test.typings": ["dialyzer --format short"],
+      "test.typings": ["cmd mkdir -p dialyzer", "dialyzer"],
       "test.coverage": ["coveralls"],
       lint: ["credo"],
       "lint.diff": ["credo diff master"],