chore: cleanup Credo warnings #1716

hauleth · 2023-10-02T16:11:30Z

Not all warnings are cleaned up yet, but some low hanging fruits are fixed
there.

Ziinc

Looks good. Would prefer smaller PRs in the future where possible to make reviewing easier

hauleth · 2023-10-04T14:28:27Z

Each commit is independent and fully self contained, so you could view them one by one.

hauleth · 2023-10-04T14:42:12Z

If you want, I can split it into set of PRs

hauleth force-pushed the chore/credo-refactorings branch from 7c08ff7 to ae0f4ca Compare October 2, 2023 19:13

Ziinc approved these changes Oct 4, 2023

View reviewed changes

hauleth added 13 commits October 5, 2023 13:19

fix: wrong usage of with

403c6f5

fix: use Enum.map_join/3 instead of Enum.map/2 |> Enum.join/2

bfcc937

fix: avoid using negative if conditions with else

bfec6e6

fix: use Enum.count/2 instead of Enum.filter/2 |> Enum.count/1

dcb63d5

fix: fuse repetitive Enum.map/2 to not create intermediate lists

6198392

chore: cleanup with usage

52d5b71

chore: cleanup fetching headers for token verification

f1cfd99

chore: replace cond with if

02537a8

fix: do not use length(data) == 0 to check for empty list

9a35c62

chore: fix consistency issue (variable binding should be after pattern)

568dedd

chore: disable controversial check that results in many false positives

17d5984

fix: remove call to dbg/1

8cb591a

chore: use Module.t/0 instead of struct definition directly when defined

63e50f9

hauleth force-pushed the chore/credo-refactorings branch from ae0f4ca to 63e50f9 Compare October 5, 2023 11:26

Ziinc merged commit 8340bf8 into Logflare:staging Oct 5, 2023
3 checks passed

hauleth deleted the chore/credo-refactorings branch October 11, 2023 15:26

Provide feedback