Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log drains rules, extends rules implementation #2059

Merged
merged 22 commits into from
May 10, 2024
Merged

Conversation

Ziinc
Copy link
Contributor

@Ziinc Ziinc commented May 1, 2024

This implements drain rules, for draining events from a source to a given backend.
UI for managing rules is based on a per-backend perspective.

In the demo, we can see that ingested data from dev.logs.up2 are forwarded (evident from the rule icon) to downstream backends, and that loadfest.test.1 and loadfest.test.2 are both receiving ingestion requests (there is no initial events being sent to these two sources).

This demo is done with webhooks adaptor.

Screen.Recording.2024-05-08.at.6.45.49.PM.mov

@Ziinc Ziinc changed the title feat: log drains rules extending initial implementation feat: log drains rules, extends rules implementation implementation May 8, 2024
@Ziinc Ziinc changed the title feat: log drains rules, extends rules implementation implementation feat: log drains rules, extends rules implementation May 8, 2024
@Ziinc Ziinc marked this pull request as ready for review May 8, 2024 10:48
lib/logflare/backends/source_sup.ex Outdated Show resolved Hide resolved
lib/logflare/logs/lql/lql_parser.ex Outdated Show resolved Hide resolved
lib/logflare/sources/source_routing.ex Outdated Show resolved Hide resolved
lib/logflare/utils.ex Outdated Show resolved Hide resolved
@Ziinc
Copy link
Contributor Author

Ziinc commented May 10, 2024

extra edge case to consider for follow up PRs

  • when there are two same rules and one gets deleted, the backend child will get stopped instead of being left as is.

@Ziinc Ziinc merged commit b92d760 into main May 10, 2024
5 checks passed
@Ziinc Ziinc deleted the feat/log-drains branch May 10, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants