feat: initial cloak implementation #2163
Merged
+391
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziinc
force-pushed
the
feat/cloak-encryption
branch
from
f904076
to
3f8233b
Compare
staaldraad
approved these changes
Aug 5, 2024
chasers
approved these changes
Aug 5, 2024
Ziinc
force-pushed
the
feat/cloak-encryption
branch
from
aba1509
to
b710426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in initial cloak implementation for encryption at rest.
Adds in a new env var that is required
LOGFLARE_DB_ENCRYPTION_KEY, and for key rotation the env var isLOGFLARE_DB_ENCRYPTION_KEY_RETIRED.Only backend config is encrypted for now.
Migration is non-destructive, this version should only add the new column
:config_encryptedPre-merge todos: