Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Loki now works with username and password in the config #2239

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

chasers
Copy link
Contributor

@chasers chasers commented Oct 25, 2024

  • Loki backend now takes the username and password from the backend config and encodes it for basic auth
  • updated and added some tests
## PATCH backend
curl -X "PATCH" "http://localhost:4000/api/backends/cafe18a6-505c-4412-b838-be2aab7ee507" \
     -H 'Authorization: Bearer 6404d476fd62450e6f76497b9eabcc7528e914b69aebb17507393c38560f6a62' \
     -H 'Content-Type: application/json; charset=utf-8' \
     -d $'{
  "metadata": {},
  "config": {
    "username": "me",
    "password": "god",
    "url": "https://logs-prod3.grafana.net/loki/api/v1/push"
  },
  "name": "loki-test",
  "type": "loki"
}'

@chasers chasers merged commit ba53ca3 into main Oct 28, 2024
5 checks passed
@chasers chasers deleted the fix/loki-username-password-support branch October 28, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants