Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: add back fullsweep_after to Task.Supervisor #2247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: add back fullsweep_after to Task.Supervisor #2247

wants to merge 1 commit into from

Conversation

Ziinc
Copy link
Contributor

@Ziinc Ziinc commented Nov 4, 2024

Added back spawn_opt for Task.Supervisor, prevents garbage buildup.
Was removed in 40db716#diff-14a0c2e2cb2fe12cfea0794ab7c068ea2f25fa332f3fb7e0351e9d63b0266adfL81

@Ziinc
Copy link
Contributor Author

Ziinc commented Nov 4, 2024

the spawn_opt gets forwarded to the underlying process
https://github.com/elixir-lang/elixir/blob/v1.17/lib/elixir/test/elixir/task/supervisor_test.exs#L31

chasers
chasers requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@chasers chasers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this didn't change the memory usage profile at all.

And I think we need to do less GC'ing.

@Ziinc
Copy link
Contributor Author

Ziinc commented Nov 5, 2024

As discussed, leaving this open for observation.

@Ziinc Ziinc force-pushed the perf/add-back-task-supervisor-fullsweep-after branch from 2907ea9 to 786d662 Compare November 7, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasers chasers chasers approved these changes

Assignees

@Ziinc Ziinc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ziinc @chasers