Merge pull request #8 from Giriraj1200/master

Release version 5.5.0
LoginRadius · Mar 30, 2021 · 1774d4b · 1774d4b
2 parents 3e3b6ea + ccd3437
commit 1774d4b
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,11 @@
+5.5.0 Release notes (2021-03-30)
+=============================================================
+
+### Enhancements
+* Upgraded FBSDK dependencies in LoginRadiusSDK for new build system of new Xcode.
+* Upgraded Eureka version to latest in Swift demo on Xcode.
+* Dropping support for Xcode versions below 11. This is in line with Apple's plans to disallow submission of Apps that do not include the iOS 13 SDK.
+
 5.4.2 Release notes (2020-08-27)
 =============================================================
 

diff --git a/Example/ObjCDemo/ObjCDemo/ViewController.m b/Example/ObjCDemo/ObjCDemo/ViewController.m
@@ -114,7 +114,7 @@ - (void) updateSocialLoadingText
 
 - (void) setupForm
 {
- [[[self navigationController] navigationBar] topItem].title = @"LoginRadius ObjCDemo 5.4.2 🇮🇳";
+ [[[self navigationController] navigationBar] topItem].title = @"LoginRadius ObjCDemo 5.5.0 🇮🇳";
 
  XLFormDescriptor * form;
  XLFormSectionDescriptor * section;
@@ -594,7 +594,7 @@ - (void) showProfileController {
  {
  if ([[LoginRadiusSDK sharedInstance] session].isLoggedIn)
  {
- NSString *additionalErrorMsg = [NSString stringWithFormat:@"%@.\n\n See our Swift Demo for an example to handle missing required fields."];
+ NSString *additionalErrorMsg = [NSString stringWithFormat:@"See our Swift Demo for an example to handle missing required fields."];
  [self showAlert:@"ERROR" message:additionalErrorMsg];
  [self performSegueWithIdentifier:@"profile" sender:self];
  }else

diff --git a/Example/SwiftDemo/SwiftDemo/ViewController.swift b/Example/SwiftDemo/SwiftDemo/ViewController.swift
@@ -182,7 +182,7 @@ class ViewController: FormViewController
 
  func setupForm()
  {
- self.navigationController?.navigationBar.topItem?.title = "LoginRadius SwiftDemo 5.4.2 🇨🇦"
+ self.navigationController?.navigationBar.topItem?.title = "LoginRadius SwiftDemo 5.5.0 🇨🇦"
  self.form = Form()
 
  //These is the just rules to toggle visibility of the UI elements

diff --git a/LoginRadiusSDK.podspec b/LoginRadiusSDK.podspec
@@ -1,7 +1,7 @@
 Pod::Spec.new do |s|
 
 s.name = 'LoginRadiusSDK'
-s.version = '5.4.2'
+s.version = '5.5.0'
 s.summary = 'Official LoginRadius SDK for iOS to integrate User Registration Service or Social Login in your app.'
 
 s.description = <<-DESC
@@ -26,7 +26,7 @@ s.source = { :git => 'https://github.com/LoginRadius/ios-sdk.git', :tag =>
 
 s.source_files = ['Sources/**/*.{h,m}']
 
-s.dependency 'FBSDKLoginKit', '~> 5.0'
+s.dependency 'FBSDKLoginKit', '~> 9.0'
 s.dependency 'SimpleKeychain', '~> 0.7.0'
 
 s.ios.frameworks = 'Foundation', 'UIKit', 'SystemConfiguration', 'Social', 'Accounts', 'SafariServices'

diff --git a/Podfile b/Podfile
@@ -1,8 +1,9 @@
+#Comment the next line if you don't want to use dynamic frameworks
 use_frameworks!
 
 workspace 'LoginRadiusSDK'
 
-platform :ios, '9.3'
+platform :ios, '9.0'
 
 target 'ObjCDemo' do
  project 'Example/ObjCDemo/ObjCDemo.xcodeproj'
@@ -15,7 +16,7 @@ end
 target 'SwiftDemo' do
  project 'Example/SwiftDemo/SwiftDemo.xcodeproj'
  pod 'LoginRadiusSDK', :path => './'
- pod 'Eureka', '<= 5.2.1'
+ pod 'Eureka'
  pod 'SwiftyJSON', '<= 4.0'
  pod 'Alamofire', '<= 4.8.2'
  #pod 'Google/SignIn', '<= 4.1.0'

diff --git a/README.md b/README.md
@@ -42,10 +42,13 @@ To integrate LRSDK into your Xcode project using CocoaPods, specify it in your P
 
 ```
 source 'https://github.com/CocoaPods/Specs.git'
-platform : ios, '9.0'
+platform :ios, '9.0'
 
 target 'TargetName' do
-pod 'LoginRadiusSDK', '~> 5.4.2'
+
+#Comment the next line if you don't want to use dynamic frameworks
+use_frameworks!
+pod 'LoginRadiusSDK', '~> 5.5.0'
 end
 
 ```

diff --git a/Sources/NativeLogin/LoginRadiusFacebookLogin.m b/Sources/NativeLogin/LoginRadiusFacebookLogin.m
@@ -37,7 +37,6 @@ - (void)loginfromViewController:(UIViewController*)controller
 
  FBSDKAccessToken *token = [FBSDKAccessToken currentAccessToken];
  FBSDKLoginManager *login = [[FBSDKLoginManager alloc] init];
- login.loginBehavior = params[@"facebookLoginBehavior"] || FBSDKLoginBehaviorBrowser;
 
  void (^handleLogin)(FBSDKLoginManagerLoginResult *result, NSError *error) = ^void(FBSDKLoginManagerLoginResult *result, NSError *error) {
  [self onLoginResult:result error:error withSocialAppName:socialAppName controller:controller];

diff --git a/Sources/SocialLogin/LoginRadiusSocialLoginManager.h b/Sources/SocialLogin/LoginRadiusSocialLoginManager.h
@@ -41,7 +41,7 @@
  * @param params dict of parameters
  These are the valid keys
  - facebookPermissions : should be an array of strings
- - facebookLoginBehavior : should be FBSDKLoginBehaviorNative / FBSDKLoginBehaviorBrowser / FBSDKLoginBehaviorSystemAccount / FBSDKLoginBehaviorWeb
+ - facebookLoginBehavior : New FB SDK is supporting FBSDKLoginBehaviorBrowser only
  recommended approach is to use FBSDKLoginBehaviorSystemAccount
  * @param socialAppName should have unique social app name as a provider in case of multiple social apps for the same provider (eg. facebook_<social app name> )
  * @param controller view controller where social login take place should not be nil