Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-663: Removing InternetExplorer attribute and other IE methods and references. #921

Merged
merged 12 commits into from
Dec 30, 2024
Merged

OSOE-663: Removing InternetExplorer attribute and other IE methods and references. #921

merged 12 commits into from
Dec 30, 2024

Conversation

milosh-96
Copy link
Member

@milosh-96 milosh-96 commented Dec 28, 2024 •
edited by jira bot
Loading

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Please resolve those before requesting a review.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
Piedone
Piedone requested changes Dec 30, 2024
View reviewed changes
.github/actions/spelling/expect.txt Outdated
@@ -17,6 +17,7 @@ createstate
creatordate
datalabels
datatables
datasource
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that it only recognized this now. Anyway, you can instead do // #spell-check-ignore-line in the Lombiq.Analyzers renovate.json5 file, since it happens only there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But where is datasource in the codebase anyway? I don't see it in the branch.
I don't think it's a compound word (nor is it a repo name like "datatables" above), so you'd spell it like DataSource, dataSource or data_source. All of those are treated as two different words by the spell checker, so you shouldn't need this exception.

Copy link
Member Author

@milosh-96 milosh-96 Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the problem is that I checked out the latest commit, so this branch is using 3f28dd4, while the dev branch is using c810f8e and in that commit there is no renovate.json5 thus this 'datasource' word doesn't exist.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here: https://github.com/Lombiq/.NET-Analyzers/blob/dev/renovate.json5#L13

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Please resolve those before requesting a review.

@Piedone
Merge remote-tracking branch 'origin/dev' into issue/OSOE-663
9979da6 
# Conflicts:
#	test/Lombiq.UITestingToolbox

[skip ci]
@Piedone Piedone merged commit 43e5a1b into dev Dec 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig left review comments

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milosh-96 @Piedone @sarahelsaig @LombiqBot