Simpler code for removing a mapping: only update the model, rely on r…

…edraw for the UI
Lorp · Apr 22, 2024 · 8aac8fb · 8aac8fb
1 parent 8f29ef1
commit 8aac8fb
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/fencer.js b/src/fencer.js
@@ -591,9 +591,10 @@ function deleteMapping() {
 		console.log(`document.querySelector('.input.location[data-index="${GLOBAL.draggingIndex}"]')`);
 		console.log(`document.querySelector('.output.location[data-index="${GLOBAL.draggingIndex}"]')`);
 
-		Q(`.arrow[data-index="${GLOBAL.draggingIndex}"]`).remove();
-		Q(`.input.location[data-index="${GLOBAL.draggingIndex}"]`).remove();
-		Q(`.output.location[data-index="${GLOBAL.draggingIndex}"]`).remove();
+		// we don’t actually have to remove the elements, because we immediately redraw the SVG
+		// Q(`.arrow[data-index="${GLOBAL.draggingIndex}"]`).remove();
+		// Q(`.input.location[data-index="${GLOBAL.draggingIndex}"]`).remove();
+		// Q(`.output.location[data-index="${GLOBAL.draggingIndex}"]`).remove();
 
 		GLOBAL.mappings.splice(GLOBAL.draggingIndex, 1);