<dimension> now uses "name" attribute, not "tag"

Lorp · Apr 30, 2024 · fbfa5b3 · fbfa5b3
1 parent 4e17ad2
commit fbfa5b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/fencer.js b/src/fencer.js
@@ -111,8 +111,6 @@ function mappingSimpleNormalize(axes, mapping) {
 
 window.onkeydown = function (e) {
 
-	console.log(GLOBAL.font.fvar.axes);
-
 	let delta = 0;
 	switch (e.key) {
 		case "ArrowUp":
@@ -1006,7 +1004,7 @@ function updateMappingsXML() {
 			mapping[i].forEach((x, a) => {
 				const axis = GLOBAL.font.fvar.axes[a];
 				if (x !== undefined && axis.defaultValue !== x)
-					str += `      <dimension tag="${GLOBAL.font.fvar.axes[a].axisTag}" xvalue="${x}"/>\n`;
+					str += `      <dimension name="${GLOBAL.font.fvar.axes[a].name}" xvalue="${x}"/>\n`;
 			});
 			str += `    </${io}>\n`;
 		});

diff --git a/src/samsa-core/samsa-core.js b/src/samsa-core/samsa-core.js
@@ -792,7 +792,9 @@ const TABLE_DECODERS = {
 		fvar.axes = [];
 		buf.seek(fvar.axesArrayOffset);
 		for (let a=0; a<fvar.axisCount; a++) {
-			fvar.axes.push(buf.decode(FORMATS.VariationAxisRecord));
+			const axis = buf.decode(FORMATS.VariationAxisRecord);
+			axis.name = font.names[axis.axisNameID];
+			fvar.axes.push(axis);
 		}
 		fvar.instances = [];
 		const includePostScriptNameID = fvar.instanceSize == fvar.axisCount * 4 + 6; // instanceSize determins whether postScriptNameID is included