Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macOS): Exit button in tray menu only hide window #158

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

XMLHexagram
Copy link
Collaborator

@XMLHexagram XMLHexagram commented Dec 3, 2024

Summary by Sourcery

Bug Fixes:

  • Fix the behavior of the exit button in the tray menu on macOS to hide the window instead of closing the application.

Copy link

sourcery-ai bot commented Dec 3, 2024

Reviewer's Guide by Sourcery

The PR modifies the close behavior on macOS by using SystemNavigator.pop() instead of appWindow.close() to properly exit the application when the close button is clicked in the tray menu.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified application close behavior for macOS
  • Added platform-specific close handling logic
  • Imported flutter/services.dart for SystemNavigator
  • Implemented SystemNavigator.pop() for macOS
  • Maintained existing appWindow.close() behavior for other platforms
lib/utils/close_manager.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @XMLHexagram - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR title mentions tray menu behavior but the change affects the general close manager. Could you clarify the scope of this change and whether it's specific to the tray menu or affects all close operations?
  • Consider using platform channels or native macOS APIs instead of SystemNavigator.pop() which is primarily designed for mobile applications. This would provide better integration with desktop-specific behaviors.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Losses Losses merged commit 9c1782b into Losses:master Dec 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants