-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(macos): add actual language placeholder files #197
Conversation
Reviewer's Guide by SourceryThis PR adds localization support for the macOS app by introducing Info.plist files for multiple languages (English, Japanese, Literary Chinese, and Simplified Chinese) in their respective .lproj directories. This ensures Xcode correctly generates the language list for the application. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @laosb - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using 'zh-Hant' (Traditional Chinese) instead of 'lzh' (Literary Chinese) as the latter is rarely used in modern applications
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
commit 39378fd Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 18:56:04 2024 +0800 feat: Implementing login dialog for the scrobble service providers commit a74ba4b Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 18:28:33 2024 +0800 feat: Implement login dialog for scrobble commit 642015b Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 17:04:09 2024 +0800 refactor: Better responsive settings box commit ba7ac99 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 16:35:09 2024 +0800 feat: Implement a dart data provider for the scrobblers commit ec8ac77 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 16:10:49 2024 +0800 feat: Implement API binding from the rust side for scrobblers commit d6a0bde Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 14:28:19 2024 +0800 feat: Adding new API design commit 4cc843b Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 14:08:11 2024 +0800 feat: Integrating update play now API commit dda4399 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 12:54:01 2024 +0800 feat: Add error action for scrobbling commit 94d6209 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 12:42:48 2024 +0800 feat: Implement update_now_playing_all commit cd70a8f Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 12:25:15 2024 +0800 fix: Now playing for listenbrainz commit 140f270 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 11:56:27 2024 +0800 refactor: Better scrobbling error handling commit f169fd5 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 11:25:50 2024 +0800 fix: Manage connection internally while scrobbling commit d8b0db2 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 09:23:49 2024 +0800 feat: A shallow integration of the scrobbling API commit c6bcd4d Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 08:42:47 2024 +0800 feat: Implement a `authenticate_all` for scrobble commit 3771378 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 08:31:09 2024 +0800 refactor: Tweak the shape of the scrobbling API commit db07cba Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 08:18:24 2024 +0800 feat: Implementing a scrobbling manager commit a2af4eb Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Thu Dec 19 07:55:34 2024 +0800 feat: Implementing token validation for listenBrainz commit 2d367ab Author: NovaDNG <gero.hsu@gmail.com> Date: Wed Dec 18 14:54:23 2024 +0000 chore: Minor fix for JA_Nise (#199) * Update JA & JA_Kana * Update Click translate * Update JA & JA_Kana & experimental JA_Nise * Experimental JA_Nise * Update JP_Nise commit 0c012cd Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 19:22:31 2024 +0800 feat: Implement listenbrainz API commit 40bf5b5 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 18:30:54 2024 +0800 fix: Libre.fm auth not working commit ed73d1e Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 17:50:03 2024 +0800 feat: Implement a scrobble random example commit 9cf65ae Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 17:31:30 2024 +0800 fix: Wrong version number commit 2e9081c Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 16:48:40 2024 +0800 feat: Implementing scrobbling commit bb55056 Author: Shibo Lyu <hi@lao.sb> Date: Wed Dec 18 16:11:16 2024 +0800 fix(macos): Add actual language placeholder files (#197) * fix(macos): Add ja, zh-Hans & lzh to xcodeproj * fix(macos): add actual l10n placeholder files commit a5d954a Author: NovaDNG <gero.hsu@gmail.com> Date: Wed Dec 18 08:09:56 2024 +0000 chore: Update JA_Nise (#198) * Update JA & JA_Kana * Update Click translate * Update JA & JA_Kana & experimental JA_Nise * Experimental JA_Nise * Update JP_Nise commit eafcc2a Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 15:41:05 2024 +0800 chore: Update .gitignore commit e5c5a6b Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 15:39:32 2024 +0800 chore: Various of performance improvement commit 31506d8 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 12:57:53 2024 +0800 chore: Bump to v1.1.0-alpha.1 commit 2a0bd66 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 12:46:14 2024 +0800 chore: Code cleanup commit 5330246 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 12:27:17 2024 +0800 fix: DnD won't display cover art commit 4ab285b Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 11:15:45 2024 +0800 fix: Unable to play independent file commit 102f833 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 09:27:10 2024 +0800 feat: Implement file DnD commit 9e4e0f3 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Wed Dec 18 08:30:31 2024 +0800 feat: Adding new dependency for DnD commit 4a28db4 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Tue Dec 17 17:54:20 2024 +0800 feat: Add new language support commit a09ae05 Author: NovaDNG <gero.hsu@gmail.com> Date: Tue Dec 17 09:39:52 2024 +0000 feat: Update JA & JA_Kana & Experimental JA_Nise (#195) * Update JA & JA_Kana * Update Click translate * Update JA & JA_Kana & experimental JA_Nise * Experimental JA_Nise commit 0890604 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Tue Dec 17 17:38:47 2024 +0800 feat: Implement independent file playback commit b79f303 Author: Losses Don <1384036+Losses@users.noreply.github.com> Date: Tue Dec 17 16:21:23 2024 +0800 fix: Update the Steam link Signed-off-by: Losses Don <1384036+Losses@users.noreply.github.com> commit b4b6b93 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Mon Dec 16 13:12:45 2024 +0800 chore: Code cleanup commit 565ee9f Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Mon Dec 16 13:11:07 2024 +0800 feat: Adapting light theme for the lyrics page commit 8425ff3 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Mon Dec 16 12:31:43 2024 +0800 feat: Auto re-calculate layout after lyrics content resized commit 082d187 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Mon Dec 16 12:17:35 2024 +0800 chore: Tweak the alignment of lyrics scrolling commit d7394d1 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Mon Dec 16 11:20:13 2024 +0800 chore: Performance improvement commit bd4ea4c Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Mon Dec 16 10:51:59 2024 +0800 fix: Lyric scrolling may not success in some cases commit 0a16f78 Author: 123Duo3 <123duo3@gmail.com> Date: Sun Dec 15 22:48:13 2024 +0800 chore: Update lzh and hans commit 029b955 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 16:57:26 2024 +0800 feat: Lyrics view supports the dock view now commit bc86a82 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 16:52:12 2024 +0800 feat: Add lyrics display for the band view commit 8c66253 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 16:33:55 2024 +0800 fix: Responsive text size for the lyrics layout commit 0008a63 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 16:27:12 2024 +0800 feat: Add adaptive layout for the lyrics page commit 19dcdb3 Author: Shibo Lyu <hi@lao.sb> Date: Sun Dec 15 16:07:16 2024 +0800 fix(macos): Add ja, zh-Hans & lzh to xcodeproj (#194) commit 91750eb Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 15:47:35 2024 +0800 fix: Add retrying while failed to get render box commit e358ff6 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 15:26:33 2024 +0800 fix: Reset the scroll position of the lyrics page after switching track commit 512bb02 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 15:16:48 2024 +0800 feat: Disable scrolling for the lyrics page commit c52f4c1 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 14:15:35 2024 +0800 chore: Tweak the visual parameter for the lyrics page commit 0a83bef Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 14:05:45 2024 +0800 chore: Tweak the visual parameter for the lyrics page commit d45eb33 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 14:02:38 2024 +0800 feat: Implement the cover art layout for the lyrics page commit bed46b5 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 13:21:58 2024 +0800 chore: Adjusting the page framing for the lyric page commit 6f3d1ea Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 13:15:48 2024 +0800 chore: Enlarge text sizing and line spacing commit af3c359 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 13:13:50 2024 +0800 feat: Adding a gradient mask to the lyric display commit 1dcf633 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 13:05:14 2024 +0800 feat: Implementing auto scrolling for the lyric view commit cb0fc41 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 12:49:27 2024 +0800 chore: Tweak the visual parameters of the lyric display widget commit 18f2ff7 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 12:36:04 2024 +0800 docs: Adding app store link commit 0e6be2b Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sun Dec 15 12:33:27 2024 +0800 feat: Improve the visual quality of lyric widgets commit 4683e88 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sat Dec 14 17:05:27 2024 +0800 feat: Improve the lyric animation implementation commit 7b38baa Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sat Dec 14 15:26:59 2024 +0800 feat: Implement a glowing light to lyrics commit 196e7f7 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sat Dec 14 15:04:38 2024 +0800 feat: Implement a blur effect for the lyric display widget commit 884df8f Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sat Dec 14 14:22:24 2024 +0800 feat: Improve multi-line lyric rendering commit 8b0967c Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sat Dec 14 13:58:10 2024 +0800 feat: Better lyric animation quality commit a5f410d Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sat Dec 14 13:41:20 2024 +0800 feat: Implement line highlightening for lyrics commit d1a79e0 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Sat Dec 14 13:06:36 2024 +0800 feat: Implement basic structure for the lyric display components commit 5801f0e Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Fri Dec 13 19:53:27 2024 +0800 feat: Implement routes and API binding for the lyrics API commit 6b6da21 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Fri Dec 13 18:34:17 2024 +0800 feat: Implement the lyric API commit 2cf1b2f Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Fri Dec 13 16:35:56 2024 +0800 feat: Implement general lyric parsing interface commit a8feba1 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Fri Dec 13 16:13:44 2024 +0800 feat: Polish the parse quality of the lrc lyric format commit bd046fa Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Fri Dec 13 15:59:13 2024 +0800 feat: Implement lrc parser commit 3096659 Author: LOSSES Don <1384036+Losses@users.noreply.github.com> Date: Fri Dec 13 13:38:49 2024 +0800 feat: Initialize the lyric parser package
This reverts commit bb55056.
So Xcode will correctly generate language list.
Summary by Sourcery
Bug Fixes: