Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update makeLatest condition to exclude alpha and beta branches #209

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: Update makeLatest condition to exclude alpha and beta branches #209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
allowUpdates: true
replacesArtifacts: false
omitBodyDuringUpdate: true
makeLatest: true
makeLatest: ${{ !(contains(github.ref_name, 'alpha') || contains(github.ref_name, 'beta')) }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider extracting the repeated release type check into a reusable expression

This expression is repeated 7 times in the workflow. Consider defining it as a workflow-level environment variable or composite action to improve maintainability. For example: env: { IS_STABLE_RELEASE: ${{ !(contains(github.ref_name, 'alpha') || contains(github.ref_name, 'beta')) }} }

Suggested implementation:

          allowUpdates: true
          replacesArtifacts: false
          omitBodyDuringUpdate: true
          makeLatest: ${{ env.IS_STABLE_RELEASE }}


          allowUpdates: true
          replacesArtifacts: false
          omitBodyDuringUpdate: true
          makeLatest: ${{ env.IS_STABLE_RELEASE }}

You'll need to add this environment variable definition at the workflow level (near the top of the file, likely just after the name: field):

env:
  IS_STABLE_RELEASE: ${{ !(contains(github.ref_name, 'alpha') || contains(github.ref_name, 'beta')) }}

Also, you'll need to replace all other occurrences of this same expression throughout the workflow file with ${{ env.IS_STABLE_RELEASE }}. Based on your comment, there are 7 total occurrences that need to be replaced.


build-windows-msix:
runs-on: windows-latest
Expand Down Expand Up @@ -142,7 +142,7 @@ jobs:
allowUpdates: true
replacesArtifacts: false
omitBodyDuringUpdate: true
makeLatest: true
makeLatest: ${{ !(contains(github.ref_name, 'alpha') || contains(github.ref_name, 'beta')) }}

build-linux:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -221,7 +221,7 @@ jobs:
allowUpdates: true
replacesArtifacts: false
omitBodyDuringUpdate: true
makeLatest: true
makeLatest: ${{ !(contains(github.ref_name, 'alpha') || contains(github.ref_name, 'beta')) }}

build-steam-sniper:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -315,7 +315,7 @@ jobs:
allowUpdates: true
replacesArtifacts: false
omitBodyDuringUpdate: true
makeLatest: true
makeLatest: ${{ !(contains(github.ref_name, 'alpha') || contains(github.ref_name, 'beta')) }}

build-macos:
runs-on: macos-latest
Expand Down Expand Up @@ -427,7 +427,7 @@ jobs:
allowUpdates: true
replacesArtifacts: false
omitBodyDuringUpdate: true
makeLatest: true
makeLatest: ${{ !(contains(github.ref_name, 'alpha') || contains(github.ref_name, 'beta')) }}

- name: Release ZIP
uses: ncipollo/release-action@v1
Expand All @@ -437,7 +437,7 @@ jobs:
allowUpdates: true
replacesArtifacts: false
omitBodyDuringUpdate: true
makeLatest: true
makeLatest: ${{ !(contains(github.ref_name, 'alpha') || contains(github.ref_name, 'beta')) }}

- name: Clean up
if: ${{ always() }}
Expand Down
Loading