-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initialize the iOS support #218
Conversation
# Conflicts: # Cargo.lock # playback/src/controller.rs
Reviewer's Guide by SourceryThis pull request implements initial iOS support. It introduces a new iOS file selector and initializes the audio session to allow background audio playback. Additionally, it updates the build process to support iOS by using Sequence diagram for iOS file selectionsequenceDiagram
actor User
participant UI as Flutter UI
participant Channel as Method Channel
participant Selector as iOS File Selector
participant System as iOS System
User->>UI: Select Directory
UI->>Channel: getDirectoryPath()
Channel->>Selector: get_directory_path
Selector->>System: UIDocumentPicker
System-->>User: Show Directory Picker
User->>System: Select Directory
System-->>Selector: Selected Path
Selector-->>Channel: Return Path
Channel-->>UI: Return Path
Class diagram for iOS integration componentsclassDiagram
class AppDelegate {
+application(didFinishLaunchingWithOptions) Bool
}
class FileSelector {
-result: FlutterResult
+shared: FileSelector
+getDirectoryPath(result: FlutterResult)
+documentPicker(controller, urls)
}
class IosFileSelector {
+shared: IosFileSelector
-platform: MethodChannel
+getDirectoryPath() Future~String?~
}
AppDelegate --|> FlutterAppDelegate
FileSelector ..|> UIDocumentPickerDelegate
note for FileSelector "Handles native iOS file selection"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @XMLHexagram - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
native/hub/build.rs
Outdated
} | ||
|
||
// #[cfg(target_os = "macos")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cleanup these code.
Summary by Sourcery
Add initial iOS support, including audio session initialization and file selection capabilities.
New Features:
Tests: