Add C++20 compliance to LLGL #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasBanana
requested changes
Jul 3, 2023
…ted due to a bad local SDK configuration.
|
Thanks for your feedback! |
LukasBanana
pushed a commit
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR introduces C++20 compliance to LLGL. By default, compiler errors occur (especially in SmallVector, which uses now removed functionality in
std::allocator. This PR aims to fix those compile errors and introduce C++20 compliance. Also, this PR includes some small updates to the pathing of the SPIR-V headers to conform with current versions of the Vulkan SDK.I was unable to find a C++ standard to which the LLGL library is complaint, but these changes are fully compliant with C++11. If C++11 support is unsatisfactory, I'm more than happy to find an alternative.
All tests were performed using the built-in project Testbed.
I am unable to test support for Metal and OpenGLES, as I lack access to the appropriate Apple hardware. The PR will remain in draft status until aforementioned support is tested, either by myself, or by another kind soul.