Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates a script to check for uneccessary and missing translations, and implements those changes #596

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Lukasdotcom
Copy link
Owner

Change Summary

Provide summary of changes with issue number if any.

Have you done all the things below

  • Run npm run format to format everything with prettier.
  • Run npm run lint and fix all errors and warnings.
  • Made sure that all database changes have update code in startup.ts and the database schema was updated in database.ts.
  • Made sure to test your changes.
  • All sql syntax would work on mysql.
  • Made sure to test your changes whith cypress by running npm test and when it is done stopping the server with ctr-c. If this fails and you don't know why look in the contributing guidelines or ask in this pull request. You can keep this unchecked and ignore it if you want to.
  • If you added any features it would be great if you tested them with cypress(Not required).
  • If you added another league did you follow all the steps in the leagues.md How to add another league.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation, changes to issue or pull request templates;)
  • style: (formatting, missing semi colons, fixing typo, etc)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing cypress tests, refactoring cypress tests; editing github actions; no production code change)
  • new league type: (added another league type like the premier league )

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@Lukasdotcom Lukasdotcom merged commit 0a76ec2 into main Oct 24, 2023
4 checks passed
@Lukasdotcom Lukasdotcom deleted the translate branch October 24, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant