Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF bugfixes in path_finder #198

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

SF bugfixes in path_finder #198

wants to merge 4 commits into from

Conversation

Luke-Poeppel
Copy link
Owner

Fixes #197.

  • There's still an onset range bug with split_extractions. See the series of Proceleusmatic in SF1.
  • I added a condition to ensure any remaining sinks that aren't in the path (but still can be) are chosen. But SF1 ignores a viable trochee at the end.
  • It seems like Tribrachs are getting consistently ignored... Probably good idea to add Ditribrach for consitency. Might solve some of this.

@codecov-commenter
Copy link

Codecov Report

Merging #198 (4a120e4) into dev (1d8ee49) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #198   +/-   ##
=======================================
  Coverage   78.46%   78.46%           
=======================================
  Files          17       17           
  Lines        2401     2401           
=======================================
  Hits         1884     1884           
  Misses        517      517           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants