Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for platform specific dependencies #153

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

sullivan-sean
Copy link
Contributor

Cargo chef currently does not support local platform specific dependencies

During the prepare stage, it does not update the version of a local dependency like

[target.'cfg(windows)'.dependencies]
local-windows-package = {path = "./path/to/local", version = "0.1.3" }

To

[target.'cfg(windows)'.dependencies]
local-windows-package = {path = "./path/to/local", version = "0.0.1" }

But all local dependencies are set to version 0.0.1, which means there is a version mismatch and cargo chef cook fails with a message like in #93

This PR fixes this behavior by adhering directly to all of the possible ways to specify dependencies defined in cargo's documentation

Copy link
Owner

@LukeMathWalker LukeMathWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Thanks for the contribution!

@LukeMathWalker LukeMathWalker merged commit 556e906 into LukeMathWalker:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants