Do not mask workspace dependencies with a source attribute #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workspace dependencies with a
source
attribute are likely to be transitive and not sourced from the workspace.Issue #, if available:
None raised.
Description of changes:
Similar to #224.
Given a workspace project:
project_a/Cargo.toml
:project_b/Cargo.toml
:The external project,
either
, depends on a crates.io-published version ofproject_b
.Therefore
project_b
is a transitive dependency ofproject_a
, however the transitiveproject_b
is different from the workspace version.Currently
crates.io:project_b
is incorrectly masked to version 0.0.1 inCargo.lock
.This PR identifies transitive dependencies by not masking dependencies with a
source
attribute. I think this is sensible and cannot think of a scenario where a workspace package would have asource
attribute.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.