feat(*): LU-3384 vp9 webm #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Bug LU-3384 · Fix transparency issue |
| @@ -41,6 +41,13 @@ const createDecoder = ({ | |||
| }); | |||
| } | |||
|
|
|||
| if (demuxer.streams[streamIndex].codecpar.name === 'vp9') { | |||
There was a problem hiding this comment.
ooo nice, I wonder if this also fixes that one off scene design Kanwar had to re-encode
There was a problem hiding this comment.
this file is kinda big (especially relative to the rest of the repo). It might be nice to trim it down to just a few seconds? Since we only seek 100ms in
michaeljherrmann
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the
webmD-ID provides us I noticed that it was using thevp9encoder instead of the previously addingvp8. In this PR, we're adding support tovp9.