Remove _utils._prepare_returns option in monthly_returns_detailedview #52
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew. It is already calculated in corresponding core function.
…ew. It is already calculated in corresponding core function. - Align code format
|
My review is in progress 📖 - I will have feedback for you in a few minutes! |
|
I have reviewed your code and did not find any issues! Please note that I can make mistakes, and you should still encourage your team to review your code as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
Note
This feature is in early access. You can enable or disable it in the Korbit Console.
What change is being made?
Remove the
_utils._prepare_returnsoption in themonthly_returns_detailedviewfunction.Why are these changes being made?
The
_prepare_returnsoption was redundant and its functionality is now handled elsewhere in the codebase, simplifying the function signature and reducing unnecessary complexity. This change ensures that themonthly_returns_detailedviewfunction is more streamlined and easier to maintain.