Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 0.0 when there is no trade, sams as monthly_heatmap_detailedview #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twkim112
Copy link
Contributor

@twkim112 twkim112 commented Aug 4, 2024

Changes:

  • Removed 0.0 when there is no trade in the monthly_heatmap function.
  • Added a mask to filter out 0.0 values.
  • Removed grid

These changes align the behavior of the monthly_heatmap function with the monthly_heatmap_detailedview function.

Here is sample figure with BTC's close data.
image

Copy link

korbit-ai bot commented Aug 4, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

category Error Handling

The code uses bare except clauses in a couple of places to catch all exceptions without specifying the exception type. This can make it difficult to identify and handle specific types of exceptions. Consider replacing the bare except clauses with specific exception types that you expect and want to handle, such as ValueError, KeyError, etc. This will make the exception handling more explicit and allow you to handle different exceptions appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant