-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for POST/PUT/PATCH calls without bodies #633
Open
igorsantos07
wants to merge
26
commits into
Luracast:master
Choose a base branch
from
igorsantos07:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing utf error in README
Fix: typos in documentation
Fix for Notice: array to string conversion on AutoLoader.php line 266
Fix typo @pformat => @Format
Removing unwanted unicode character from documentation
…c/examples/_007_crud/DB/Session.php on line 58
…ises decoding by avoiding Obj::toArray() Closes#621
Update to try fixing when a string is expected Validator.php
Remove curly brace syntax for PHP 7.4 support
…rt-to-master Fix PHP 7.4 support.
Those calls may be made only with path or query params, and still they fail validation because JSON refuses to decode an empty string.
Think this patch is stale as this fix is in 3.1.0 -
|
You are right @richardeaxon! |
Ok, so....
|
@igorsantos07 reopened the pull request. Yes 3.1 is stable and I didn't do a good job documenting it that way. Also, there is a newer version of restler at https://github.com/Arul-/reactive-restler which will be brought to this repository soon! |
@igorsantos07 can you change it to point to v2 branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those calls may be made only with path or query params, and still they fail validation because JSON refuses to decode an empty string.
By the way, by reading
Restler::getRequestData()
I see that DELETE calls do not accept body params? I know this seems uncommon, but is it correct? An API might want to include further filters in the body to allow the deletion to happen.