Add missing const qualifiers, unify code style #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added an explicit initialization of the CityTile pointer to fix #145 |
|
Code is ready to go! Just tested it on kaggle. Thanks! |
|
@StoneT2000 In case you need help to prepare the cpp kit for another season or challenge, I'd be willing to contribute again. |
|
Thanks! We will consider reaching out before launching the next year's challenge's kits. Are you on discord? @themmj |
|
Sweet. Yes its MMJ#3534 , we already had a small convo in the questions channel about the const qualifiers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first change adds the
constqualifiers I mentioned in Discord.The second change makes the code more readable and unifies the style. There were some redundant things (like unnecessary
;, usingthis->and unneeded copy constructions) and some inconsistencies in style (initialization of members in the constructor body or as an initializer list and where the curly braces are placed). Also added some whitespace to aid in readability or fix indentation mismatches. Overall just adjusted parts of the code to be in line with the rest.I've not touched main.cpp to avoid merge conflicts for users.
If you want me to remove the second change from the PR and only keep the Position.hpp changes feel free to tell me. I just thought it might help.